validate repo config when when changes are proposed - #412
Merged
Conversation
Previously, if a repo's Hubcast config was invalid and a dev opened a PR/branch to fix the issue, we'd read from the default branch config and report the old error. This PR adds the following - if hubcast.yml was changed in the branch/PR, validate that config and report the status back to the user - report the exception text to users when validation fails - add user-friendly parsing to the YAML and pydantic config errors - rename the hubcast-error check to hubcast-config to avoid confusion for successful statuses This change requires an additional API call to check the files changed by a PR. Signed-off-by: Caetano Melone <melone1@llnl.gov>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Caetano Melone <melone1@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a repo's Hubcast config was invalid and a dev opened a PR/branch to fix the issue, we'd read from the default branch config and report the old error.
This PR adds the following
This change requires an additional API call to check the files changed by a PR.
closes #394
--
examples of new behavior: